linebender / linebender/vello

Prohibit zero-sized pixmaps

Open
#1,269 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
4.3k
Forks
300
Avg merge
2d 13h
Merged PRs (30d)
61

Description

Currently, it is possible to create pixmaps where the width or height is 0. This can lead to panics when we start sampling the image when rendering. We probably should prohibit the user from creating such pixmaps.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the pixmap creation API and the existing tests for pixmap dimensions or rendering. Confirm how zero width and height are currently accepted and identify the expected rejection behavior. Done means pixmaps with either dimension set to zero can no longer be created, preventing the rendering-time sampling panic.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.