linebender / linebender/vello

Fix sweep gradient impl for COLR glyphs in Vello Classic

Open
#1,228 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-research
Dominant language
Rust
Stars
4.3k
Forks
300
Avg merge
2d 13h
Merged PRs (30d)
61

Description

We probably need to apply the COLR side of https://github.com/linebender/vello/pull/1221 in Vello Classic. I've also added a TODO comment for this in #1224:

https://github.com/linebender/vello/blob/edbcf4e3e6bf76cfbc5a8585e981bd9d15825e2c/vello/src/scene.rs#L1058-L1059

We should also add a test which uses the colr_test_glyphs (which are already in the repository):

https://github.com/linebender/vello/tree/edbcf4e3e6bf76cfbc5a8585e981bd9d15825e2c/examples/assets/colr_test_glyphs

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the TODO in vello/src/scene.rs around lines 1058-1059 and compare the COLR-related changes in pull request #1221. Use the existing examples/assets/colr_test_glyphs for the requested test. Done means Vello Classic handles sweep gradients for COLR glyphs and the test covers that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.