linebender / linebender/svgtypes
Consider providing hash implementation for public types
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 82
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
This will involve some work around the floats to make them hashable. In the case of SVG types I think we can even do the simple `.to_bits().hash()` with additional check for the `NaN` value, but also we can use more robust way like https://github.com/reem/rust-ordered-float/blob/master/src/lib.rs
If you accept this I can open a PR
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the public SVG types and their float fields, then compare the proposed bit-based approach with the linked rust-ordered-float implementation. Done means the accepted public types have a defined Hash implementation, including explicit behavior for NaN values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- computer-graphics
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100