linebender / linebender/skribo

layout_run function does not work correctly on ubuntu 18.04

Open
#18 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
335
Forks
35
PR merge metrics
No merged PRs in 30d

Description

The returned glyph_id in the glyph_infos is always zero after shaping,

Adding hb_ot_font_set_funcs(hb_font) to the layout_run function fixes it. For more details describing the same problem see this issue: https://github.com/maps4print/azul/issues/125#issuecomment-479172471

I didn't make a PR as i'm not sure adding this causes troubles on windows/macos.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The entry point is layout_run; begin by reproducing the Ubuntu 18.04 case and inspecting glyph_infos after shaping. Check the proposed hb_ot_font_set_funcs(hb_font) change against the linked Azul discussion, then verify that glyph_id is populated without regressions on Windows or macOS.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, ubuntu
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.