linebender / linebender/runebender
[ui] Bug: values in "font properties" only apply when changing cursor focus
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 799
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Description
If I edit a value in the "font properties" dialog, it will only apply if I click on another text box in that same dialog, or if I press the TAB key.
For instance, if I edit the font family name and immediately click the "Done" button, the edit is ignored.
This dialog seems to mix two mental models:
* "Immediate editing" - changes are applied as we tweak the data in the dialog
* "Commit editing" - dialogs that use a "Done" or "OK" button to make the edits effective only when the dialog is closed.
We should choose a single model and stick to it.
For instance, if we choose "immediate editing", then I'd suggest applying the changes at every value change (such as when pressing a key or when pasting from text clipboard). Then the "Done" would be redundant, so it could be ditched and the user would simply click out of the dialog area to close it.
For "commit editing", all changes would apply upon clicking "Done", not earlier. And would use the contents of the text fields.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in the font properties dialog, then locate the dialog implementation and trace how text-field values are committed when focus changes and when Done is clicked. Decide on one editing model, ensure the chosen behavior consistently preserves the edited values, and verify both keyboard and mouse workflows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100