linebender / linebender/piet

Move more tests into piet-common

Open
#415 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
Rust
Stars
1.4k
Forks
98
PR merge metrics
No merged PRs in 30d

Description

There are a bunch of tests duplicated across various backends, and it makes sense to move these into piet-common.

The only tests that *really* need to be backend-specific are tests that rely on platform fonts or behaviour related to platform fonts, like things for hit-testing?

There are also a few tests that were removed from piet-common because of cairo toy-text; these include the `missing_font_is_missing` test.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the duplicated tests across the backends with the tests in piet-common, paying attention to the tests removed because of cairo toy-text, including `missing_font_is_missing`. Done means shared tests live in piet-common while tests requiring platform fonts or platform-font hit-testing behavior remain backend-specific.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.