linebender / linebender/parley

Use `FromStr` rather than `fn parse`

Open
#98 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue help wanted
Dominant language
Rust
Stars
736
Forks
120
Avg merge
1d 3h
Merged PRs (30d)
53

Description

In fontique there are some methods parse which could instead use FromStr and be able to use the str::parse function as detailed here: https://doc.rust-lang.org/std/primitive.str.html#method.parse

These methods are:

  • GenericFamily::parse()
  • Stretch::parse()
  • Style::parse()
  • Weight::parse()

This was suggested by @DJMcNab in #97.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the four named methods in fontique: GenericFamily::parse(), Stretch::parse(), Style::parse(), and Weight::parse(), then read the discussion in issue #97 and the Rust str::parse documentation. Implement the corresponding FromStr behavior while preserving existing parsing results, and verify the project’s existing tests or checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.