linebender / linebender/parley
Tests comparing "max_advance" and "by_length" line-breaking don't compare trailing whitespace
Open
Beginner friendly
Nobody has claimed this yet.
bug
testing
- Dominant language
- Rust
- Stars
- 736
- Forks
- 120
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 53
Description
Discovered when debugging https://github.com/linebender/parley/pull/680. There is a pre-existing issue where the tests comparing the two line-breakers for equivalence:
- Don't assert trailing whitespace
- Don't compare the rendered snapshots (these are different in some cases!)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the tests that compare the max_advance and by_length line-breakers for equivalence. Start by reading those comparisons and their snapshot assertions; done means the tests also assert trailing whitespace while accounting for cases where rendered snapshots legitimately differ.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100