linebender / linebender/parley
Consider removing `underline` and `strikethrough` styles
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 736
- Forks
- 120
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 53
Description
These styles:
- Do not affect layout
- Could be implemented on top of Parley without dedicated support
- Require unnecessary (and expensive) full rebuilds of the layout if they change (when such a change should really only require a "repaint").
The way to implement underline/strikethrough if we remove the dedicated styles would be to associate an ID with a span of text using the "brush" style. The styles associated with that ID can then be updated without causing a relayout.
---
The alternative would be to keep the dedicated styles but allow them to be updated without triggering a relayout.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the dedicated underline and strikethrough styles alongside the brush style and the layout-update behavior they trigger. Compare removing the dedicated styles with allowing them to update without relayout. Done means one approach is selected and the resulting style changes require repainting rather than unnecessary full layout rebuilds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100