linebender / linebender/parley

All methods on `PlainEditor` should also be available on `PlainEditorDriver`

Open
#200 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue help wanted
Dominant language
Rust
Stars
736
Forks
120
Avg merge
1d 3h
Merged PRs (30d)
53

Description

The new "driver" API makes sense from an efficiency point of view. But it is super annoying that some methods are only available on `PlainEditorDriver` and some are only available on `PlainEditor`. This can be worked around by doing `driver.editor.`, but this is an unnecessary API wart.

I can see two possibilities:
- We manually add all methods
- We implement `Deref` and `DerefMut` for `PlainEditorDriver`

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the definitions and public methods for PlainEditor and PlainEditorDriver, then compare their APIs and evaluate the two approaches described: forwarding methods or implementing Deref and DerefMut. Done means the driver exposes all methods currently available on the editor without requiring driver.editor.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend-api-design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.