linebender / linebender/norad

norad should not reorder layers

Open
#343 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

spec compliance
Dominant language
Rust
Stars
61
Forks
16
PR merge metrics
No merged PRs in 30d

Description

when norad parses the UFO layers, it reorders them such that the first one is always the default:

https://github.com/linebender/norad/blob/0b9e43334551861dbdd75732785d0cb5f3431568/src/layer.rs#L88-L93

However this is incorrect or unwarranted, because the UFO spec never says the default layer should be the first. Font editors may rely on the specific ordering of layers in layercontents.plist (which is deliberately typed as an array and not a dict) for various purposes.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/layer.rs at lines 88-93 and review how parsed UFO layer contents are ordered. Done means preserving the order from layercontents.plist instead of moving the default layer to the first position.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.