linebender / linebender/norad

`crate::font::load_layers` and `LayerSet::load` should agree whether layercontents.plist is required or not

Open
#223 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
61
Forks
16
PR merge metrics
No merged PRs in 30d

Description

https://github.com/linebender/norad/blob/d4af02bdc2f07f5cffd3d7b26fd06891cff32d44/src/font.rs#L640-L642

vs.

https://github.com/linebender/norad/blob/d4af02bdc2f07f5cffd3d7b26fd06891cff32d44/src/layer.rs#L45-L50

considering `LayerSet::load` is public.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked implementations in src/font.rs around load_layers and src/layer.rs around LayerSet::load, then compare how each handles layercontents.plist. Determine the consistent public behavior for the two entry points and consider how existing tests cover it; done means both loaders agree on whether the file is required.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.