Mutating setters on druid_shell::Window should have `set_` names.
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 9.7k
- Forks
- 565
- PR merge metrics
- No merged PRs in 30d
Description
At least including `set_resizeable`, and `set_show_titlebar`, although the latter name isn't great. I might change it to something like `titlebar_is_visible` and `set_titlebar_is_visible` or something?
> Hmm must not have noticed this, but these should be called `set_`.
_Originally posted by @cmyr in https://github.com/xi-editor/druid/pull/773_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating druid_shell::Window and its resizeable and show_titlebar mutating methods, then search for their call sites. Decide the consistent setter names, including whether show_titlebar needs a clearer visibility-based name, and update affected references so the Window API and its users use the chosen names.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100