Add `should_close` method to WinHandler
Open
Nobody has claimed this yet.
discussion
enhancement
shell
- Dominant language
- Rust
- Stars
- 9.7k
- Forks
- 565
- PR merge metrics
- No merged PRs in 30d
Description
When the user closes a window, either via a command or with the 'traffic lights', we should have some call that the framework can make where the application has the opportunity to cancel closing of that window, for instance to save open files.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating WinHandler and tracing how window-close commands and traffic-light closes enter the framework. Define the expected should_close behavior so the application can cancel either close path, including unsaved-file scenarios. Done when both paths consult it and cancellation prevents the window from closing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100