linebender / linebender/druid

calc example doesn't use button widgets

Open
#2,096 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
9.7k
Forks
565
PR merge metrics
No merged PRs in 30d

Description

The calc example doesn't use `Button` or a similar widget that is semantically a button. Instead, it adds a click handler to the label (or actually, the label's container). This is a problem for accessibility, especially when taking keyboard focus into account (see #2095). I know why calc doesn't use the `Button` widget; `Button` brings its own styling, which isn't the desired appearance for calc. I suggest adding a widget called something like `CustomButton` that gives the caller total control over the appearance, as they have now with a clickable label, but implements the correct accessibility and keyboard focus behavior.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the calc example and the existing Button widget, then read issue #2095 for the keyboard-focus context. Compare the current clickable label or its container with the proposed CustomButton behavior. Done means the calc example uses a semantically button-like widget while retaining its custom appearance and correct accessibility and keyboard-focus behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
accessibility, desktop-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.