AppLauncher::configure_env should take FnOnce
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 9.7k
- Forks
- 565
- PR merge metrics
- No merged PRs in 30d
Description
### Description
Currently it is not possible to move values into the closure used by `AppLauncher::configure_env`. This is a problem when you want to do some one-time setup on the closure which requires moving outer values.
### Proposed solution
`AppLauncher::configure_env` should take a `FnOnce`. Since this function is only used once when calling `AppLauncher::launch`, which already takes `mut self` by value, this shouldn't break anything.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at AppLauncher::configure_env and follow its use when AppLauncher::launch consumes self. Verify the closure can move captured outer values while preserving the existing one-time configuration behavior, then run the relevant Rust tests or checks to confirm the API change does not break callers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100