AppDelegate::window_removed gets called too early
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 9.7k
- Forks
- 565
- PR merge metrics
- No merged PRs in 30d
Description
AppDelegate::window_removed gets called while all the window's widgets are still alive and hold copies of the state. This is really bad because it makes it impossible to transfer ownership of the state out of the window.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the AppDelegate::window_removed lifecycle and the point at which the window's widgets are destroyed. Confirm when widget-held state copies are still alive, then identify the lifecycle ordering that should be changed. Done means window_removed no longer runs before the widgets and their state are released, with a regression test covering the ordering.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100