linebender / linebender/druid

Selecting multiple files / directories is not actually implemented.

Open
#1,067 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted
Dominant language
Rust
Stars
9.7k
Forks
565
PR merge metrics
No merged PRs in 30d

Description

A bug I ran into just now:

I currently have:

```
let dialog_options = FileDialogOptions::new()
.select_directories()
.multi_selection();

let window = WindowDesc::new(build_schauglas)
.menu(MenuDesc::new(LocalizedString::new("menubar")).append(
MenuDesc::new(LocalizedString::new("file").with_placeholder("File")).append(
MenuItem::new(
LocalizedString::new("open").with_placeholder("Open"),
Command::new(SHOW_OPEN_PANEL, dialog_options),
),
),
));
```

And in my delegate, I am simply printing out whatever command gets in:

```
-> bool {
debug!("Cmd: {:?}", cmd);
if let Some(file_info) = cmd.get(OPEN_FILE) {
return true;
}

false
}
```

this gives me the following outputs:

- When selecting a single directory: `Cmd: Command { symbol: "druid-builtin.open-file-path", payload: Any }`
- When selecting multiple:

Info:
- Windows 10
- Druid 0.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing FileDialogOptions::multi_selection() through the SHOW_OPEN_PANEL command and the delegate's OPEN_FILE handling, using the single-directory and multiple-selection examples in the issue. Check where the selected paths should be emitted and verify that selecting multiple files or directories produces a command containing all selections rather than no command.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.