weak_sdk_framework not being passed?
Nobody has claimed this yet.
- Dominant language
- Starlark
- Stars
- 209
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
There is a requirement to add AdServices.framework but I need to include it as weak to support earlier devices without crashing them.
I added :
weak_sdk_frameworks = [
"AdServices",
]
But somehow the framework is still not available on the newer devices (14.3+).
I found that your rules do not pass weak_sdk_frameworks into the native objc_library might cause this issue. The code here.
Since I'm still a beginner in Bazel, I would love to hear your thoughts if this is expected or not.
I would love to create the pull request for you if correct.
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at apple/objc_static_framework.bzl lines 229-231 and inspect how weak_sdk_frameworks is passed to the native objc_library. Verify whether AdServices is weakly linked and available on supported newer devices while preserving compatibility with earlier devices; done means the framework setting behaves as requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios
- Domain
- build-system, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100