Is Picasso absolutely needed for Line SDK?
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 149
- Forks
- 54
- PR merge metrics
- No merged PRs in 30d
Description
This is more as a question or feature request instead of an issue.
## What did you do?
We integrate Line SDK for login purpose and realized Line SDK bringing in the entire Picasso image loading library. We use glide to load images in our app. The introduction of Picasso SDK makes our final app bigger.
## What did you expect?
While Line SDK is a light SDK for login purpose, it is surprising that it brings in Picasso. We searched Line SDK code base and realized there are only 2 use cases where Picasso is used to load typical images into ImageView with a place holder. So we are wondering if the Picasso SDK can be removed and Line SDK can use the typical BitmapFactory to load those 2 images.
https://github.com/search?q=repo%3Aline%2Fline-sdk-android+Picasso.get%28%29&type=code
What do you think and I can help making the change if you prefer :)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked repository code search for the two Picasso.get() usages and inspect how the SDK declares Picasso as a dependency. Determine whether those image-loading uses can be replaced without changing their placeholder behavior; done means the login SDK no longer brings in Picasso while those images still load correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100