Remove allowBackup in application tag
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 149
- Forks
- 54
- PR merge metrics
- No merged PRs in 30d
Description
## Is it a security issue?
no
## What did you do?
Consume Line SDK 5.4.1 to 5.8.0. They declare allowBackup as false in AndroidManifest.
## What did you expect?
I believe the consumer should declare this, not the library. If an application have allow backup set to true, they need to use `tools:replace` tag to override the value from this library.
This is somehow acceptable.
However, if there is another library which set the flag to true, the overriding of the consumer result in an error during lint. For example, here is my stacktrace
```
Attribute application@allowBackup value=(false) from [com.linecorp.linesdk:linesdk:5.8.0] AndroidManifest.xml:22:9-36
is also present at <...> AndroidManifest.xml:20:9-35 value=(true).
```
## What happened actually?
The library has allowBackup declaration
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the SDK's AndroidManifest.xml and the manifest-merger conflict described in the issue. Confirm where the application-level allowBackup declaration is provided, then verify that removing it prevents the conflict with another library's manifest.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100