line / line/line-sdk-android

Text_highligh Specifies the same color ID

Open
#129 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
149
Forks
54
PR merge metrics
No merged PRs in 30d

Description

Is it a security issue?

Not

What did you do?

The Colors directory in the SDK has many color values that are too generic, such as text_highlight, background, etc. This time our app has the same color ID as the Line SDK, which causes the LINE SDK colors to overwrite our app. We solved this problem in other ways

What did you expect?

I hope the Line SDK can consider this aspect of naming, such as adding a prefix or a relatively unique ID

What happened actually?

The same color ID causes the line color to cover our app
our app
color name="text_highlight">@color/ck_orange
line app
color name="text_highlight">#07bf3f

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the SDK's Colors directory and inspect the Android color resource names, especially text_highlight, background, and other generic IDs. Compare them with application resource names to define a naming scheme that avoids collisions; done means SDK colors no longer overwrite identically named app colors.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.