line / line/gradle-scripts

Provide a way to track changes in upstream source code

Open
#138 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
80
Forks
34
Avg merge
1d 21h
Merged PRs (30d)
1

Description

We copy and paste code from upstream classes if we need to modify the source code.
[This](https://github.com/line/armeria/blob/91c787f0a087499453103480f0fc8ab01072f9ab/core/src/main/java/com/linecorp/armeria/server/Http2ServerUpgradeCodec.java#L65) is one of the examples.
If the copied source code is changed due to bug fixes or improvements, we also need to modify our code.
If we provide a way to tell the upstream change, (e.g. when we update dependencies), it would be a lot easier to maintain our code.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with core/src/main/java/com/linecorp/armeria/server/Http2ServerUpgradeCodec.java at the referenced code and inspect how this repository handles dependency updates. Determine how upstream changes could be identified and what maintenance workflow the issue should support; done means a concrete, maintainable way to track relevant upstream changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.