line / line/centraldogma

Do not expose `internal.thrift.CentralDogmaException`

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking change defect
Dominant language
Java
Stars
668
Forks
135
Avg merge
4d 19h
Merged PRs (30d)
7

Description

When the Java client library fails, `internal.thrift.CentralDogmaException` is raised. This exposes an internal class as well as our implementation detail (Thrift). We should convert it into a protocol-agnostic generic exception type.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the Java client library by tracing where failures expose internal.thrift.CentralDogmaException and how that exception reaches the public API. Identify the existing client exception types and their tests, then verify that client failures expose a protocol-agnostic exception without exposing the Thrift implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.