should `centraldogma-client` module have Armeria dependency?
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 668
- Forks
- 135
- Avg merge
- 4d 19h
- Merged PRs (30d)
- 7
Description
`centraldogma-client` module was designed not to have Armeria dependency because users might want to send a request using a different client.
However, I haven't seen such cases and if users would want to implement the client, they could refer to the spec and implement only the specific part of the methods they need. (e.g. `watcher` and `watchFile`)
So I think we can add Armeria dependency to `centraldogma-client` module to leverage Armeria's APIs and simplify the implementation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the centraldogma-client module and review how its request methods, especially watcher and watchFile, are currently implemented. Compare those paths with the Armeria APIs and the Central Dogma specification; done means the module uses the dependency without removing support for its documented client behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100