line / line/centraldogma

Remove Thrift support in favor of RESTful API

Open
#59 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking change
Dominant language
Java
Stars
668
Forks
135
Avg merge
4d 19h
Merged PRs (30d)
7

Description

.. because:

- libthrift isn't stable enough yet, e.g. 0.10.0 introduced breaking changes since 0.9.x. We do not want to ship two client library JARs - one for Thrift 0.9 and the other for 0.10.0.
- A client library can have fewer dependencies, especially without libthrift and Armeria.

To make this come true, we need to:

- #64 Revise our RESTful API & implementation so that it covers all features provided by the current Thrift service.
- Rewrite the client library so it uses the RESTful API.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing issue #64 and the current Thrift service and client library to inventory the features that must be covered. The work is done when the RESTful API provides equivalent functionality, the client library uses it, and the Thrift-related dependencies and support can be removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.