line / line/centraldogma

Client library with fewer dependencies

Open
#49 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

new feature
Dominant language
Java
Stars
668
Forks
135
Avg merge
4d 19h
Merged PRs (30d)
7

Description

A user want to use CentralDogma with Netty 4.0 (e.g. Apache Flink uses 4.0) but because Armeria uses methods that is newly added in Netty 4.1, it causes NoSuchMethod exception.

Currently, he/she can relocate Netty 4.1 by himself/herself.

To solve this, we can 1) make Armeria shade Netty or 2) refactor the client library so it has Armeria-based provider and `URLConnection`-based provider.

Related: https://github.com/line/armeria/issues/705

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the CentralDogma client library and the related Armeria issue 705. Compare the two proposed approaches: shading Netty in Armeria or separating an Armeria-based provider from a URLConnection-based provider. The work is done when the client can be used with Netty 4.0 without the reported NoSuchMethodException.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.