lincc-frameworks / lincc-frameworks/hyrax

Refactor `resolve_results_dir`

Open
#889 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
41
Forks
7
Avg merge
5d 1h
Merged PRs (30d)
8

Description

This portion of the code looks like it's from the ancient times, and probably isn't relevant anymore: https://github.com/lincc-frameworks/hyrax/blob/a377f7148a807377adf870a27f74c90b3ce82c76/src/hyrax/config_utils.py#L670-L673

We should refactor it since it seems like it's making assumptions about being used by `infer`, but has call locations outside of `infer.py`.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/hyrax/config_utils.py around lines 670-673, then inspect resolve_results_dir call locations outside infer.py and compare them with the infer usage. Determine which assumptions are no longer valid and refactor the function so it works consistently for all mentioned call locations without relying on infer-specific behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.