lincc-frameworks / lincc-frameworks/hyrax
Move dataset-specific configs out of the `data_set` config table.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 41
- Forks
- 7
- Avg merge
- 5d 1h
- Merged PRs (30d)
- 8
Description
Currently many config parameters for various different dataset classes are grouped together in the toml file table `data_set`.
We should go ahead and create subtables and percolate the configurations down correctly (probably at the same time that do the major "data_set"|"dataSet" -> "dataset" rename).
i.e.
```
[data_set]
[data_set.hsc_dataset]
param_1 = 0
param_2 = "thing"
[data_set.hyrax_random_dataset]
param_1 = "stuff"
param_2 = 42
etc...
```
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the TOML configuration table named `data_set` and the dataset class configuration-loading entry points. Trace how the existing `data_set`/`dataSet` names are consumed, then verify that each dataset class receives only its nested configuration and that the rename is applied consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100