lincc-frameworks / lincc-frameworks/hyrax

Write simple test_visualize test suite

Open
#384 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

visualization
Dominant language
Python
Stars
41
Forks
7
Avg merge
5d 1h
Merged PRs (30d)
8

Description

There aren't any smoke tests that check that visualization is working. The end to end test does call h.visualize, but we recently saw that those tests weren't running. (They were marked "slow" and we were skipping slow tests)

Since the end to end tests were covering train, infer, umap and visualize, and because we already have specific unit tests for train, infer and umap, we should just focus on writing a small suite for visualize.

Once the visualize unit tests are in place, we should:
- Remove the end to end tests
- Remove the "not slow" arguments in pre-commit pytest-check, testing-and-coverage.yml, and smoke-test.yml

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing end-to-end tests that call h.visualize and the project's existing unit-test conventions. Add a small visualize test suite, then remove those end-to-end tests and the “not slow” arguments from pre-commit pytest-check, testing-and-coverage.yml, and smoke-test.yml; done means visualization is covered without slow-test exclusions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.