lima-vm / lima-vm/lima

change `type Foo = string` to `type Foo string` for strict type checking

Open
#5,142 5 comments 0 reactions 0 assignees View on GitHub
good first issue kind/refactoring
Dominant language
Go
Stars
21.9k
Forks
957
Avg merge
2d 6h
Merged PRs (30d)
53

Description

```console
$ git grep -n '^type .* = ' | grep -v '.pb.go'
pkg/downloader/downloader.go:41:type Status = string
pkg/guestagent/sockets/sockets.go:10:type Kind = string
pkg/guestagent/sockets/sockets.go:20:type State = byte
pkg/instance/start.go:391:type watchHostAgentEventsTimeoutKey = struct{}
pkg/instance/start.go:399:type launchingShellKey = struct{}
pkg/limatype/lima_instance.go:15:type Status = string
pkg/limatype/lima_yaml.go:77:type CPUType = map[Arch]string
pkg/limatype/lima_yaml.go:171:type SFTPDriver = string
pkg/limatype/lima_yaml.go:232:type ProvisionMode = string
pkg/limatype/lima_yaml.go:271:type ProbeMode = string
pkg/limatype/lima_yaml.go:285:type Proto = string
pkg/networks/usernet/config.go:18:type SockType = string
pkg/sshutil/format.go:15:type FormatT = string
```

`type Foo = string` should be changed to `type Foo string` so that type checking can be enforced on compilation

Contributor guide

Open the contributing guide

Research direction

Start with the provided git grep results and inspect the type declarations in pkg/downloader/downloader.go, pkg/guestagent/sockets/sockets.go, pkg/instance/start.go, pkg/limatype/*.go, pkg/networks/usernet/config.go, and pkg/sshutil/format.go. Convert the listed aliases to defined types, then verify that the project compiles and type checking is enforced.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.