lima-vm / lima-vm/lima

Use `go tool` in Makefile

Open
#4,606 0 comments 0 reactions 0 assignees View on GitHub
area/test
Dominant language
Go
Stars
21.9k
Forks
957
Avg merge
2d 6h
Merged PRs (30d)
53

Description

We use `go tool` to run `shfmt`, `go-licenses`, etc. in CI, but in the Makefile we run whatever version is installed locally on the `PATH`.

Shouldn't we always use the same mechanism?

Also is there a reason not to run other tools, like `golangci-lint` via `go tool` as well?

And if we use `go tool` everywhere in the `Makefile`, shouldn't we use `make` in CI instead of hard-coding the lint commands?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.