lima-vm / lima-vm/lima

`shellEnvBlock` should block `*PASSWORD*`, `*TOKEN*`, `*SECRET*`, etc. by default?

Open
#4,058 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
21.9k
Forks
957
Avg merge
2d 6h
Merged PRs (30d)
53

Description

https://github.com/lima-vm/lima/blob/9e96fe10f0ef008f69b2d4719079641e30764b88/pkg/envutil/envutil.go#L14-L43

I thought the list was initially designed to block `*PASSWORD*`, `*TOKEN*`, `*SECRET*`, etc. by default, but did we change the design on purpose? (because the list cannot be robust?)

Can't find the relevant conversation in:
- https://github.com/lima-vm/lima/issues/3430
- https://github.com/lima-vm/lima/pull/3830

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.