lima-vm / lima-vm/lima

Logging questions

Open
#240 3 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Go
Stars
21.9k
Forks
957
Avg merge
2d 6h
Merged PRs (30d)
53

Description

While working on `sudo nerdctl` port forwarding I found myself in need of capturing logs. This is when I noticed the guest agents logs were not easy to work with. I wanted to do a PR to make some more of the logging useful but I wasn't sure what was supposed to happen and I have some opinions on what I'd like to do. So, here are my questions...

- The guest agent logs are directly through the logrus package which the host agent uses an instance of logrus. Is the different methods of using logrus intentional? See next question for more detail.
- The guest agent logs go to stderr. It's run as a daemon so there is no logging. Is this intentional or should the logs be moved to a file? If they are a file I would set most output to debug level and then run the guest agent with info level so most data would not be logged by default. This would be to not fill up VM disk space.
- logrus is in maintenance mode (see the README). The project recommends other logging packages. I was wondering if you would be open to a logging API and then logrus as the implementation being used. This would make it easier to change later if needed. I would go with https://github.com/masterminds/log-go. Note, I wrote that so this is a shameless plug.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.