lima-vm / lima-vm/lima

Disk size is parsed using `units.RAMInBytes`

Open
#1,153 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Go
Stars
21.9k
Forks
957
Avg merge
2d 6h
Merged PRs (30d)
53

Description

I was surprised that `100MB` is parsed as `100MiB`, as I expected the field to accept the same kind of units as Kubernetes resources (https://github.com/kubernetes/apimachinery/blob/master/pkg/api/resource/quantity.go).

Not sure if the Kubernetes package is re-usable from outside Kubernetes. If it isn't, then I think it would make more sense to parse disk sizes using `units.FromHumanSize` because disk sizes are customarily specified in decimal SI units.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.