lilott8 / lilott8/BioScript

VolumeTracker should deal with Phi nodes appropriately

Open
#79 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue
Dominant language
Python
Stars
53
Forks
16
PR merge metrics
No merged PRs in 30d

Description

The volume tracker does not appropriately handle phi nodes.

The issue arises when a phi node exists in a loop header, where there is a use prior to a def, and has the following structure:

```
before_loop:
a0 = ...
loop_header:
a1 = phi(a0, a1)
loop_body:
... = use a1
```

A test case has been added to the volume tracking testing harness using tests/assays/probabilistic_pcr.bs as the model.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the volume-tracking testing harness and the existing test case using tests/assays/probabilistic_pcr.bs. Reproduce the loop-header phi scenario with a use before the definition, then trace how the volume tracker handles the phi node. Done means the added test passes and this loop structure is handled appropriately.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.