lilott8 / lilott8/BioScript

Get_consequence doesn't work correctly

Open
#14 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Python
Stars
53
Forks
16
PR merge metrics
No merged PRs in 30d

Description

https://github.com/lilott8/ChemType/blob/master/chemicals/epa_manager.py#L86

`return self.reactive_table[t1][t1]` should change to: `return self.reactive_table[t1][t2]`

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open chemicals/epa_manager.py at line 86 and inspect get_consequence. Confirm how t1 and t2 are used in the reactive table, then verify that the lookup uses t2 for the second key and returns the expected consequence.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.