liip / liip/packager

Error when the registry contains multiple empty lines

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
22
Forks
4
PR merge metrics
No merged PRs in 30d

Description

If `/usr/local/packager/registry.log` contains 2 or more empty lines the following error happens:

```
Traceback (most recent call last):
File "/usr/local/packager/packager.py", line 561, in
c.run()
File "/usr/local/packager/packager.py", line 50, in run
cmd_obj.run(self, params, options)
File "/usr/local/packager/packager.py", line 153, in run
registry = PackageRegistry()
File "/usr/local/packager/packager.py", line 439, in __init__
self.packages = self.__parseRegistry(self.__registry)
File "/usr/local/packager/packager.py", line 451, in __parseRegistry
package, version = line.split(':')
ValueError: need more than 1 value to unpack
```

OSX 10.13.2
Python 2.7.10

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure with multiple empty lines in /usr/local/packager/registry.log, then inspect packager.py around PackageRegistry.__init__ and __parseRegistry at line 451. The issue is done when a registry containing empty lines no longer raises the reported ValueError and valid package entries still parse.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.