liip / liip/extend-block-example-wp-plugin

save className of multiple SelectControl values

Open
#5 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
50
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Thank you very much for this example plugin, it's helping me learn Gutenberg.

Your example of multiple SelectControl: https://github.com/liip/extend-block-example-wp-plugin/blob/feat/additional-attribute-logic/assets/js/spacing-control.js

I noticed that only the last attribute .has-spacing-bottom-$ is saved. The .has-spacing-top-$ is ignored.

I'm trying to fix it without success. Could you give me at least a hint on how to solve this issue?

Thanks and Cheers!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with assets/js/spacing-control.js, linked in the issue, and inspect how the multiple SelectControl values are saved. Confirm the behavior by checking that both .has-spacing-bottom-$ and .has-spacing-top-$ class names are persisted rather than only the last value.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.