Generalise the timeout parameter in actions
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 459
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
I have a pre-release action that takes some time (`ant` on a GWT project), and it sometimes triggers the Symfony Process component’s 60 s timeout. I’m thinking of making a PR to add a `timeout` option to the `command` action, but before I start working, I should ask:
* Is this desired?
* Should I add it to the `composer-stability-check` and `composer-json-check` prerequisites as well? They use the `executeCommandInProcess` method of `BaseAction`, that uses the Process component;
* Should I also set the default timeout to a higher value, to avoid having to set it on all potential long-running commands in the `rmt.yml` file?
* Would a global timeout option at the root level of the `rmt.yml` file be necessary?
Thanks for making RMT, I love it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the command action and BaseAction::executeCommandInProcess, then trace how the Symfony Process component's timeout is configured for command and prerequisite actions. Clarify with maintainers whether timeout should be per action, global in rmt.yml, or both; the work is done when the supported scope and default behavior are agreed and covered consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- cli, release
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100