liip / liip/LiipTestFixturesBundle

[Feature Request]: Append parameter in loadAllFixtures method

Open
#362 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
PHP
Stars
178
Forks
48
PR merge metrics
No merged PRs in 30d

Description

Hello!

I commonly set the `append` parameter to true when loading fixtures via `loadFixtures`.

I recently started splitting my fixtures into many small classes, and now I would rather use `loadAllFixtures` to avoid having to write them all down in an array. However, I see that the `append` option is not present in `loadAllFixtures`. Is there a reason for this? It would seem very useful to me. Let me know if my use-case is weird or I am doing something wrong.

Thanks in advance!

### Describe alternatives you've considered

Of course, one could simply use `loadFixtures` listing all the existing fixtures as an array. It just seems inconvinient.

### Additional context

```
abstract public function loadFixtures(array $classNames = [], bool $append = false): AbstractExecutor;
public function loadAllFixtures(array $groups = []): ?AbstractExecutor
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the loadAllFixtures and loadFixtures entry points and compare their current implementations and tests. Verify how the append option behaves for loadFixtures, then confirm that loadAllFixtures accepts and forwards the option without breaking existing fixture-loading behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, symfony
Domain
database, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.