3.x not yet compatible with symfony 8.x
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.7k
- Forks
- 386
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 3
Description
`symfony/http-foundation` 8.x [removed support](https://github.com/symfony/http-foundation/blob/8.1/CHANGELOG.md) for calling `get` on the request object:
```
Remove Request::get(), use properties ->attributes, query or request directly instead
```
This is still being used by the resolver controller: https://github.com/liip/LiipImagineBundle/blob/fbd2e18e7a744d5f487b7db6ad73fce599916e1d/src/Controller/ImagineController.php#L62
Since there is no direct requirement on `symfony/http-foundation` it is possible to install the incompatible version alongside, because the [`framework-bundle` allows both 7.x and 8.x](https://github.com/symfony/framework-bundle/blob/7.4/composer.json#L30)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/Controller/ImagineController.php around line 62, where the resolver controller calls get on the Symfony request object. Check the Symfony HttpFoundation 8.x changelog and the bundle's existing controller tests, then verify the controller no longer uses the removed API and that the compatibility tests pass with Symfony 8.x.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, symfony
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100