liip / liip/LiipImagineBundle

VIPS + Qualty params not working

Open
#1,601 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
1.7k
Forks
386
Avg merge
1d 10h
Merged PRs (30d)
3

Description

Hello.

This code doesn't work because rokka/imagine-vips doesn't have a quality option, but instead has multiple quality options for each image format.

    filter_sets:
        name:
            quality:              50

This works:

    filter_sets:
        name:
            quality:              50
            jpeg_quality:              50

Quality should work for all VIPS image formats. Please fix. Thank you!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the VIPS quality configuration and how the bundle maps the generic quality parameter to format-specific options. Compare the working jpeg_quality example with the generic quality setting; done means quality is applied for all VIPS image formats without requiring a format-specific parameter.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, symfony
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.