liip / liip/LiipFunctionalTestBundle
Restore test with max_query_count: 1
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 648
- Forks
- 179
- PR merge metrics
- No merged PRs in 30d
Description
One test of AllowedQueriesExceededException and some other things were broken on the main branch, I fixed these issues in another PR: #604 I'm not happy with the change of max_query_count from 1 to 0 in the internal tests but if it allow to have a version compatible with Symfony 6, it will be worth it.
Originally posted by @alexislefebvre in https://github.com/liip/LiipFunctionalTestBundle/issues/598#issuecomment-1126584504
Here is the related commit: https://github.com/liip/LiipFunctionalTestBundle/pull/604/commits/93a080a3adf9dfef6cc434c50fc092c90cca42c9
It looks like the queries to database are not counted properly.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the AllowedQueriesExceededException test and the internal tests changed in PR #604, focusing on the max_query_count change from 1 to 0. Check how database queries are counted under Symfony 6 compatibility, then restore the test with max_query_count: 1 and verify the query-counting tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php, symfony
- Domain
- databases, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100