lightpanda-io / lightpanda-io/browser

createBrowserContext should not create the default browsercontext

Open
#783 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Zig
Stars
35.5k
Forks
1.7k
Avg merge
21h 13m
Merged PRs (30d)
262

Description

Issue discovered here: https://github.com/lightpanda-io/browser/pull/777#discussion_r2149411411

From puppeteer, without calling createBrowserContext, the defaultBrowserContext already exist. This works for LightPanda already.
Calling create should not return the same context-id as the default browsercontext as revealed in the linked discussion.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the linked pull-request discussion first, then locate the createBrowserContext entry point and the existing defaultBrowserContext initialization. Verify the behavior against Puppeteer expectations: calling createBrowserContext should produce a context ID distinct from the default browser context.

Written by the indexing model from the issue text.

Assessment

Tech stack
zig
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.