lightninglabs / lightninglabs/taproot-assets

multi: perform cross repo integer audit

Open
#96 4 comments 0 reactions 2 assignees Assigned to @bhandras View on GitHub
audit integers security
Dominant language
Go
Stars
525
Forks
150
Avg merge
2d 15h
Merged PRs (30d)
31

Description

In a few areas we do things like use a uint64 for a locktime, when in practice from Bitcoin's PoV a uint32 is all that's needed.

There're other areas where we mix signed and unsigned integers as well, and need to cast back and forth between them.

This also trickles down into the database: sqlite doesn't actually support `uint64` type natively. Also depending on what top-level types you use, `sqlc` may translate them into unexpected integers.

When should do a general audit/run-thru of all the integer usage within the project, particularly as they interact w/ the general database structure, and also the SMT itself.

Related to #37

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.