lightninglabs / lightninglabs/taproot-assets

[feature]: Consolidate `lnd`/`tapd` `fn` packages to single source

Open
#943 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement tech debt
Dominant language
Go
Stars
525
Forks
150
Avg merge
2d 15h
Merged PRs (30d)
31

Description

Consolidate the fn package between lnd and tapd, then only use one

When using WhenSome() closures the two sources can lead to confusion and compilation errors if the wrong fn
package is used.

Originally posted in https://github.com/lightninglabs/taproot-assets/pull/938#discussion_r1632387551

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the separate fn packages used by lnd and tapd, then trace their WhenSome() call sites to identify the conflicting APIs. Consolidation is complete when one fn package is used consistently and the project compiles without the wrong-package errors described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.