lightninglabs / lightninglabs/taproot-assets
[feature]: Use more sophisticated margin for invoice acceptor
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 525
- Forks
- 150
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
### Background
Currently our [invoice acceptor](https://github.com/lightninglabs/taproot-assets/pull/912/files#diff-5761d8e06dd213a5ff31aca2abe70153485d5d7832da64b35d371c0303e42bbdR170-R172) for lightning payments has some room for error for the amount sent by the sending party. Due to inaccuracies that may be produced by translating an asset to msat, we want to still accept invoices that are slightly off.
For assets with very high value this behavior may be taken advantage of by malicious senders, as they may try to abuse this artificial breathing room to their advantage.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the invoice acceptor implementation linked in the issue, focusing on how asset amounts are translated to msat and where the current error margin is applied. Define a margin that still tolerates conversion inaccuracies without creating exploitable slack for high-value assets; the issue does not name tests or files beyond the linked implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- payments
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100