lightninglabs / lightninglabs/taproot-assets
update defaultNetwork to mainnet
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 525
- Forks
- 150
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 31
Description
Background
The demon use the testnet network by default
https://github.com/lightninglabs/taproot-assets/blob/34f3283ac2cfecadce9a43f4de203a327be53fbd/tapcfg/config.go#L51
Due to
https://github.com/lightninglabs/taproot-assets/pull/567/commits/d78e93b40acd093b3a3fa69f6ac4c719300b0aa1
in #567
We can either change the default to mainnet now, to reflect that the alpha is compatible with mainnet, or wait until we update tag from alpha to beta.
Users can be confused about having to set the --network=mainnet CLI flag
Issue will be satisfied by:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at tapcfg/config.go around line 51 and inspect commit d78e93b, which introduced the testnet default. Update the defaultNetwork behavior so mainnet is used without the --network=mainnet flag, then run the repository's Go tests and verify the issue's requested default is reflected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100