lightninglabs / lightninglabs/taproot-assets

[feature]: Use a single abbreviation of "address" throughout the client

Open Beginner friendly
#596 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
525
Forks
150
Avg merge
2d 15h
Merged PRs (30d)
31

Description

### Background

There are two main interactions a user will have with addresses:
- Receiving funds (e.g. creating an address)
- Sending funds (e.g. sending to an address)

Currently, the command `tapcli **addrs** new` uses a different abbreviation for address than `tapcli assets send --**addr**`.

Sadly, my mind cannot comprehend this or remember which is which, which is why I propose to use a single abbreviation throughout the client; `ADDR` as we already use `lncli sendpayment --pay_addr` and `lncli sendcoins --addr` in LND (although variations of the variable `addrs` exist in LND as well).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the client command definitions and help text for the `addrs` and `addr` abbreviations, starting with `tapcli addrs new` and `tapcli assets send --addr`. Standardize the address abbreviation as `ADDR` throughout the client, then verify that the affected commands expose consistent names and usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.